Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back oc10 app release #4427

Merged
merged 10 commits into from
Dec 8, 2020
Merged

Bring back oc10 app release #4427

merged 10 commits into from
Dec 8, 2020

Conversation

LukasHirt
Copy link
Contributor

@LukasHirt LukasHirt commented Dec 7, 2020 •
edited
Loading

Add build steps to makefile to create a phoenix-app.tar.gz, create appinf, change icons to reflect the ones in app switcher and add docs on how to deploy the app.

@LukasHirt LukasHirt self-assigned this Dec 7, 2020
@update-docs

This comment has been minimized.

Sign in to view
@LukasHirt LukasHirt marked this pull request as ready for review December 7, 2020 14:49
@LukasHirt LukasHirt requested a review from micbar December 7, 2020 14:49
LukasHirt
LukasHirt commented Dec 7, 2020
View reviewed changes
docs/deployments/oc10-app.md Show resolved Hide resolved
appinfo/info.xml Show resolved Hide resolved
phil-davis
phil-davis reviewed Dec 7, 2020
View reviewed changes
docs/deployments/oc10-app.md Outdated Show resolved Hide resolved
docs/deployments/oc10-app.md Outdated Show resolved Hide resolved
docs/deployments/oc10-app.md Outdated Show resolved Hide resolved
pmaier1
pmaier1 approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@pmaier1 pmaier1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 👍

Will check info.xml at a later point before the release.

micbar
micbar reviewed Dec 8, 2020
View reviewed changes
Makefile.release Outdated Show resolved Hide resolved
micbar
micbar requested changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@LukasHirt
Copy link
Contributor Author

@micbar Ready for re-review. Both comments addressed

@micbar
Copy link
Contributor

micbar commented Dec 8, 2020

tested it. Seems to work. We will test the details in qa.

micbar
micbar approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Super Fast progress!

@LukasHirt
Copy link
Contributor Author

Had twice in a row failures in CI. I tried to rebase the PR, maybe that'll help

@LukasHirt LukasHirt merged commit 54b7fb7 into master Dec 8, 2020
@LukasHirt LukasHirt deleted the oc10-app branch December 8, 2020 15:54
ownclouders pushed a commit that referenced this pull request Dec 8, 2020
commit 54b7fb7
a963eeb 
Merge: 7387234 71f88cc
Author: Lukas Hirt <lhirt@owncloud.com>
Date:   Tue Dec 8 16:54:40 2020 +0100

    Merge pull request #4427 from owncloud/oc10-app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis left review comments

@micbar micbar micbar approved these changes

@pmaier1 pmaier1 pmaier1 approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees

@LukasHirt LukasHirt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LukasHirt @micbar @phil-davis @pmaier1